feat(background-image): pf-background-image element - #2588
Merged
Conversation
🦋 Changeset detectedLatest commit: ad5c33a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
demo
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bennypowers
reviewed
Aug 23, 2023
bennypowers
reviewed
Aug 23, 2023
zeroedin
marked this pull request as ready for review
August 25, 2023 13:38
zeroedin
marked this pull request as draft
August 25, 2023 13:39
bennypowers
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
<pf-background-image>elementTODO
Determine if container based examples need to exist. Background image which states they can be part of an "area of a page": Summary: A background image allows you to place an image in the background of your page or area of a page.Answer: Discussion with the PatternFly team resulted in the following "The current implementation doesn’t support “Area of page” and "sounds like we should update the summary of that component as it currently is described on the website. I’ll open an issue" Bug - incorrect summary of BackgroundImage component patternfly-org#3729
Testing Instructions
Notes to Reviewers